-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency axios-mock-adapter and fix the token unit tests #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest k6 run output1
Footnotes
|
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
Signed-off-by: Olga Bulat <[email protected]>
5015a6c
to
edabb80
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
obulat
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
dependencies
Pull requests that update a dependency file
🧰 goal: internal improvement
Improvement that benefits maintainers, not users
🟩 priority: low
Low priority and doesn't need to be rushed
🧱 stack: frontend
Related to the Nuxt frontend
🟨 tech: javascript
Involves JavaScript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Originally, this was a renovate PR to update a dependency. However, this dependency was added to be used in the
api-token
tests, which were disabled during the Nuxt 3 migration, and wan't used in the codebase.Instead of updating
axios-mock-adapter
, I removed it here and fixed theapi-token
unit tests.This PR contains the following updates:
^1.22.0
->^2.0.0
Release Notes
ctimmerm/axios-mock-adapter (axios-mock-adapter)
v2.1.0
Compare Source
v2.0.0
Compare Source
Breaking Changes 💥
Drop node versions lower than v18 (https://github.com/ctimmerm/axios-mock-adapter/pull/390)
Change the parameters of the methods to align it to the one of axios. (https://github.com/ctimmerm/axios-mock-adapter/pull/387)
The last parameter must be a config object with
{params, headers}
instead of just the headers.If you've always only used two parameters, you won't have to change anything.
Methods with data param:
mock.onPost(url, data, headers)
>mock.onPost(url, data, {params, headers})
mock.onPut(url, data, headers)
>mock.onPost(url, data, {params, headers})
mock.onPatch(url, data, headers)
>mock.onPatch(url, data, {params, headers})
mock.onAny(url, data, headers)
>mock.onAny(url, {data, params, headers})
Methods without data param:
mock.onGet(url, {params}, headers)
>mock.onGet(url, {params, headers})
mock.onDelete(url, {params}, headers)
>mock.onDelete(url, {params, headers})
mock.onHead(url, {params}, headers)
>mock.onHead(url, {params, headers})
mock.onOptions(url, {params}, headers)
>mock.onOptions(url, {params, headers})
An error is reported if one accidentally passes the headers directly instead of `{headers: {}}.
e.g.
Error: Invalid config property Header-test provided to onPatch. Config: {"Header-test":"test-header"}
Configuration
📅 Schedule: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.