-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEA-3240: Support Dart v3 #116
Draft
matthewnitschke-wk
wants to merge
10
commits into
master
Choose a base branch
from
dart3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
kirkrichardson-wk
approved these changes
Jan 29, 2024
Is there anything I can do to help get this in? Dart 3 has been out for a while now, and a fair few projects have started moving over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEA-3240
I recently discovered that analyzer
v5.13.0
can successfully analyze dart 3 code, which in relation means that scip-dart can run on dart3 codeThis pr updates the upper bound of the scip-dart cli to allow indexing using any dart version above
2.19.6
, and below dartv4
This pr also adds a special snapshot project just for these dart3 features. Reviewing the results of that snapshot file should verify dart 3 features ran on an analyzer
v5.13
The previous "dart 3 support branch" has now become the analyzer v6 branch: #68, since this bumps the required lower bound up to dart 3, it will need to stay in draft state