Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-3240: Support Dart v3 #116

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

FEA-3240: Support Dart v3 #116

wants to merge 10 commits into from

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Jan 28, 2024

FEA-3240

Issue Status

I recently discovered that analyzer v5.13.0 can successfully analyze dart 3 code, which in relation means that scip-dart can run on dart3 code

This pr updates the upper bound of the scip-dart cli to allow indexing using any dart version above 2.19.6, and below dart v4

This pr also adds a special snapshot project just for these dart3 features. Reviewing the results of that snapshot file should verify dart 3 features ran on an analyzer v5.13

The previous "dart 3 support branch" has now become the analyzer v6 branch: #68, since this bumps the required lower bound up to dart 3, it will need to stay in draft state

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title initial support for dart3 Support dart 3 Jan 28, 2024
@matthewnitschke-wk matthewnitschke-wk changed the title Support dart 3 Support Dart v3 Jan 28, 2024
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review January 28, 2024 23:59
@bender-wk bender-wk changed the title Support Dart v3 FEA-3240: Support Dart v3 Jan 28, 2024
@isaacharrisholt
Copy link
Contributor

Is there anything I can do to help get this in? Dart 3 has been out for a while now, and a fair few projects have started moving over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants