Default to agency ID of 1 for agencies without ID. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ object AgencyFile extends GtfsFile[Agency] { | |||
| for (s <- CsvParser.fromPath(path)) { | |||
| agencies += | |||
| Agency( | |||
| id = s("agency_id").get.intern, | |||
| id = s("agency_id").getOrElse[String]("1"), | |||
There was a problem hiding this comment.
I think the interned string here is an important memory optimization and should be kept around. @echeipesh, would you agree?
There was a problem hiding this comment.
In this particular case you're not going to have too many agencies. But overall you're correct, Interning strings saves a ton of memory even just for the parsing process.
Also, you probably need to apply the same logic for agency_id field when reading the routes.txt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217.