Skip to content

Commit

Permalink
Removes all times CMNoir/greyscale-vision is set for ghost (#636)
Browse files Browse the repository at this point in the history
## About The Pull Request
Removes all times ghost vision is set to or animated towards CMNoir
greyscale-o-vision.
Keeps the CMNoir color matrix list incase of future use.

Gif of it not greyscaling your screen when you ghost

![dreamseeker_2025-01-28_17-03-03](https://github.com/user-attachments/assets/bcd91ddf-ef93-4556-b42d-4006cbdf5634)
## Why It's Good For The Game
To be admittedly rather brash, the greyscale vision just makes observing
worse, it doesn't add any flavor or theme or any other since of
aesthetic but rather wears and tears on your eyes as you try to look at
the cool stuff thats happening through a faded lens. Best case it's a
nuisance and makes any recording of in-game footage from a
ghost/observer perspective hard to look at and at worst it just drives
people away from staying to observe or atleast be more interested in a
game they're not directly participating in.

## Changelog
:cl: Vondiech/Citruses
del: Ghost greyscale vision is no more.
/:cl:
  • Loading branch information
mrhugo13 authored Feb 4, 2025
1 parent edbf7fa commit 0ab8c1e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion code/modules/admin/admin_verbs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ GLOBAL_PROTECT(admin_verbs_hideable)
message_admins("[key_name_admin(usr)] re-entered corpse")
ghost.can_reenter_corpse = TRUE //force re-entering even when otherwise not possible
ghost.client.show_popup_menus = 0
ghost.client.color = CMNoir
ghost.reenter_corpse()

SSblackbox.record_feedback("tally", "admin_verb", 1, "Admin Reenter") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
Expand Down
8 changes: 0 additions & 8 deletions code/modules/mob/dead/observer/observer.dm
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,6 @@ var/list/CMNoir = list(0.3,0.3,0.3,0,\
var/aghosted = FALSE
var/auspex_ghosted = FALSE

/mob/dead/observer/Login()
..()
if(client && !aghosted)
animate(client, color = CMNoir, time = 30)
client.color = CMNoir
//There was observer music here. It's gone now.

/mob/dead/observer/Initialize()
set_invisibility(GLOB.observer_default_invisibility)

Expand Down Expand Up @@ -319,7 +312,6 @@ Works together with spawning an observer, noted above.
// [ChillRaccoon] - setting mob icons
ghost.icon = src.icon // [ChillRaccoon] - We should transfer mob visuals to the ghost
ghost.overlays = src.overlays // [ChillRaccoon] - Overlays too, else we will not see wounds, hair, skin, and etc.
ghost.color = CMNoir // [ChillRaccoon] - it makes our ghost looks like noir
// -------
ghost.key = key
ghost.client.init_verbs()
Expand Down
2 changes: 0 additions & 2 deletions code/modules/mob/living/carbon/human/death.dm
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ GLOBAL_LIST_EMPTY(dead_players_during_shift)
call_dharma("judgement", U)
if(!(real_name in U.mind?.dharma?.deserving) && U.real_name == lastattacker)
call_dharma("killfirst", U)
if(client)
animate(client, color = CMNoir, time = 10) // [ChillRaccoon] - make life/death transition looks more beauty
to_chat(src, "<span class='warning'>You have died. Barring complete bodyloss, you can in most cases be revived by other players. If you do not wish to be brought back, use the \"Do Not Resuscitate\" verb in the ghost tab.</span>")

/mob/living/carbon/human/proc/makeSkeleton()
Expand Down

0 comments on commit 0ab8c1e

Please sign in to comment.