Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly removes Diablerist quirk #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boy2mantwicethefam
Copy link
Contributor

@boy2mantwicethefam boy2mantwicethefam commented Jan 26, 2025

Turns out that the mysterious "Test Quirk" was actually the remnants of the "Black Secret" quirk that was removed shortly after the codebase was forked from VtM13, which turns your character into a diablerist (does not affect the preferences, so removing the quirk removes the diablerist status unless you diablerized someone). This PR properly disables it.

I am not deleting the comment to clean up the codebase, it's a little piece of history.

Comment on lines +654 to +660

/datum/quirk/diablerist/on_spawn()
if(iswerewolf(quirk_holder) || isgarou(quirk_holder))
return
var/mob/living/carbon/human/H = quirk_holder
H.diablerist = TRUE
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/datum/quirk/diablerist/on_spawn()
if(iswerewolf(quirk_holder) || isgarou(quirk_holder))
return
var/mob/living/carbon/human/H = quirk_holder
H.diablerist = TRUE
*/

We have git for the history of the repo. That's like, all that git is for.

Copy link
Contributor Author

@boy2mantwicethefam boy2mantwicethefam Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't show up unless someone specifically tries to dig it up, which is pretty rare (only really involves using git blame).
I prefer leaving it commented out, the worst it does is having "diablerist" show up a few more times when searching for words in a codebase but it's basically microscopic since the codebase isn't massively cluttered with random comments that would actually be problematic when trying to code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants