-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2 bottom pattern hit map not used in fax #491
Comments
Yes, this is correct. I agree changing the value in the ini would be the easy solution for now, including the bottom PMT hit map would be the best solution long-term. |
…G4 update of LCE map. See issue: #491
* s2_mean_area_top_fraction updated to latest MC value. See #491 * Truth information of fax updated. In updated version, peak times are the hit times of PE on PMTs, removing the contribution from dead PMTs. Also photoionization after pulses are recorded as well. * PMT after pulse updated. Enable the AP area > 1PE. The multi-PE after pulse informaton is configurated for each PMT, based on AP analysis done by Julien * Make Chris's little robot not screaming anymore * Activate the magic dead PMT avoiding flag.
I'll change the title since I understand you've resolved the second part of the issue. Once a top+bottom S2 map is made, we'll still have to change fax to support it (and still support top-only maps ideally). |
Fyi: The latest S2 map is extracted from MC for top+bottom PMTs. Changes in PAX/FAX are still missing. |
After a more close look at code:
Suggest to:
The text was updated successfully, but these errors were encountered: