Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 bottom pattern hit map not used in fax #491

Open
mcfatelin opened this issue Feb 9, 2017 · 3 comments
Open

S2 bottom pattern hit map not used in fax #491

mcfatelin opened this issue Feb 9, 2017 · 3 comments

Comments

@mcfatelin
Copy link
Contributor

After a more close look at code:

  • I found that currently the S2 bottom pattern hit map is not used in simulating the S2 hits. See L637 of pax.simulation. The bottom S2 pattern is assumed to be uniform.
  • In the mean time, fax uses a constant value of s2-top-fraction to allocate photons for a simulated S2 on top/bottom PMTs (See L245 of XENON1T.ini ). And the value is not updated to the latest value got from new MC simulation (See here ). This is the reason we see discrepancy of AFT between data and MC in Joey's note Fig.3

Suggest to:

@JelleAalbers
Copy link
Contributor

Yes, this is correct. I agree changing the value in the ini would be the easy solution for now, including the bottom PMT hit map would be the best solution long-term.

mcfatelin added a commit that referenced this issue Feb 14, 2017
This was referenced Feb 14, 2017
JelleAalbers pushed a commit that referenced this issue Feb 18, 2017
* s2_mean_area_top_fraction updated to latest MC value. See #491

* Truth information of fax updated. In updated version, peak times are the hit times of PE on PMTs, removing the contribution from dead PMTs. Also photoionization after pulses are recorded as well.

* PMT after pulse updated. Enable the AP area > 1PE. The multi-PE after pulse informaton is configurated for each PMT, based on AP analysis done by Julien

* Make Chris's little robot not screaming anymore

* Activate the magic dead PMT avoiding flag.
@JelleAalbers
Copy link
Contributor

I'll change the title since I understand you've resolved the second part of the issue. Once a top+bottom S2 map is made, we'll still have to change fax to support it (and still support top-only maps ideally).

@JelleAalbers JelleAalbers changed the title S2 bottom pattern hit map not used in fax & s2_mean_area_fraction_top not compatible with the map used S2 bottom pattern hit map not used in fax Feb 4, 2018
@l-althueser
Copy link
Member

Fyi: The latest S2 map is extracted from MC for top+bottom PMTs. Changes in PAX/FAX are still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants