Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fax update for the campaign. #502

Merged
merged 2 commits into from
Feb 15, 2017
Merged

Conversation

mcfatelin
Copy link
Contributor

@mcfatelin mcfatelin commented Feb 14, 2017

New update of fax specifically for the use of the analysis campaign. The main changes are:

  1. PMT gains and gain sigmas are now from PMT WG, which accommodate the condition in the first science run.
  2. Change the s2_area_mean_top_fraction to the updated value in MC. See Issue#491
  3. Corrected the PMT after pulse probability. Previous one was 100 times higher.
  4. The time resolution of ion-residual PMT after pulse is added. Values are from JulienW
  5. Also the uniformly time-distributed PMT after pulse was implemented. See summary note for more details of such type of PMT after pulses. Because it can happen very close to the primary hit, it is potentially a important responsible for peak finding/classification/clustering efficiency loss.

However this will not be the last update of fax during the analysis campaign. The foreseen update on fax would be the implementation of multi-PE PMT after pulse generation.

… PMT AP time resolution added. 3) PMT AP probability corrected. 4) Uniformly time-distributed PMT AP added.
Copy link
Contributor

@JelleAalbers JelleAalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, simulated events look good

@JelleAalbers JelleAalbers merged commit 76bcb8b into master Feb 15, 2017
@JelleAalbers JelleAalbers deleted the fax_update_for_campaign_v2 branch February 15, 2017 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants