Add a script for PR update checking #1273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make some plugins and play with the dependency so that we can track them
|
Was this already discussed in Team A, if not can we discsuss this PR? |
This is not discussed. I am still implementing things into it. |
… the script accordingly
for more information, see https://pre-commit.ci
…r_changes_phase_b
Report PR changes phase B
|
I have cleaned the json after running all checking. I will let @JYangQi00 have some time to implement the check of the highest plugin that is promised to be unchanged. I think if any change is found, then there must be some issue and a big error message should be raised. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I have added the functionality to test for the changes to the highest level plugin. "Highest level" in this context actually has a pretty clear definition. Here, the "level" or "layer" that a plugin lies on is the amount of layers which need to be available for the plugin of interest to be made. Here is an example output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
See this issue for the motivation of this script: #1259
Can you briefly describe how it works?
Every time a PR is made, this script can be ran to find out which new plugins are added, which are deleted, and what the change in the proportion of number of NaNs (0 or -1) for float (integer) fields are. This script also finds which plugins are the lowest-level changed plugins, and checks for changes in the plugins one layer up the dependency tree.
Can you give a minimal working example (or illustrate with a figure)?
There are two branches made for testing:
test_lineage_changesandtest_plugin_changes.test_lineage_changesadds a pluginS2FWHM(which does what it sounds like) as well as a new data typeevent_nansprovided by theGiveNansplugin which adds a float field that is half-filled with nans, and an integer field that is half -1's. Thentest_plugin_changesdeletesS2FWHMand replaces it withS2FWHM2which puts in a NaN to the first element of the chunk in thes2_fwhmfield. Theevent_nansintest_plugin_changesis also changed to only place a nans/-1 in the first element of the chunk. The script is ran like so:./check_lineage_updates.sh <old_branch> <new_branc> <output_folder> <run_id>And an example can be:
./check_lineage_updates.sh track_lineage_changes test_plugin_changes /scratch/midway2/jyangqi/strax_data 025423Here's the output of that command:
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.