Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO_COLOR environment variable standard #632

Merged
merged 2 commits into from
Jul 29, 2024
Merged

NO_COLOR environment variable standard #632

merged 2 commits into from
Jul 29, 2024

Conversation

Xithrius
Copy link
Owner

@Xithrius Xithrius commented Jul 19, 2024

Closes #629

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 17.86%. Comparing base (03d07e2) to head (2cd6e36).
Report is 1 commits behind head on main.

Files Patch % Lines
src/utils/styles.rs 0.00% 83 Missing ⚠️
src/ui/components/utils/input_widget.rs 0.00% 10 Missing ⚠️
src/ui/components/chat.rs 0.00% 8 Missing ⚠️
src/handlers/data.rs 0.00% 6 Missing ⚠️
src/ui/components/dashboard.rs 0.00% 5 Missing ⚠️
src/ui/components/emote_picker.rs 0.00% 5 Missing ⚠️
src/ui/components/utils/search_widget.rs 0.00% 5 Missing ⚠️
src/ui/components/debug.rs 0.00% 4 Missing ⚠️
src/ui/components/error.rs 0.00% 4 Missing ⚠️
src/handlers/app.rs 0.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   18.14%   17.86%   -0.29%     
==========================================
  Files          41       42       +1     
  Lines        5346     5430      +84     
==========================================
  Hits          970      970              
- Misses       4376     4460      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xithrius Xithrius marked this pull request as ready for review July 27, 2024 00:28
All styles are now statics

[pre-commit.ci] auto fixes from pre-commit.com hooks

Appeased the linter, removed the vscode crate extension
@Xithrius Xithrius force-pushed the main branch 2 times, most recently from fa84276 to eda2068 Compare July 27, 2024 02:39
@Xithrius Xithrius merged commit 31bcc1c into main Jul 29, 2024
4 checks passed
@Xithrius Xithrius deleted the no-color branch July 29, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: NO_COLOR standard implementation
1 participant