feat/#42: Signup Complete, Pending View 구현

[jinukeu]

💡 Issue

• Resolved: [Feature] 회원가입 Complete, Pending View #42

🌱 Key changes

• SignUp Complete, Pending View 구현했습니다.

✅ To Reviewers

📸 스크린샷

스크린샷

Summary by CodeRabbit

• 새로운 기능

  • 회원가입 프로세스에 대기 및 완료 상태 추가
  • 회원가입 단계별 맞춤 UI 컴포넌트 도입

• UI 개선

  • 회원가입 완료 및 대기 상태를 위한 새로운 일러스트레이션 추가
  • 헤더 컴포넌트의 유연성 향상 (선택적 아이콘 및 클릭 핸들러)

• 사용자 경험

  • 회원가입 상태에 대한 명확한 피드백 메시지 제공
  • 승인 대기 상태에 대한 안내 추가

[coderabbitai]

Walkthrough

이 풀 리퀘스트는 회원가입 프로세스의 새로운 단계를 추가하고 관련 UI 컴포넌트를 구현합니다. SignUpStep 열거형에 Pending 상태를 도입하고, 해당 상태에 대한 새로운 컨텐츠 컴포넌트를 생성했습니다. 또한 회원가입 완료 상태를 위한 UI와 일러스트레이션, 문자열 리소스를 추가했습니다. 헤더 컴포넌트도 nullable 파라미터를 지원하도록 수정되었습니다.

Changes

파일	변경 요약
core/designsystem/src/main/java/.../YappHeaderActionbar.kt	헤더 액션바 파라미터를 nullable로 변경
feature/signup/src/main/java/.../SignUpScreen.kt	새로운 회원가입 단계 컨텐츠 추가
feature/signup/src/main/java/.../SignUpStep.kt	Pending 상태 추가
feature/signup/src/main/java/.../content/CompleteContent.kt	회원가입 완료 화면 컴포넌트 생성
feature/signup/src/main/java/.../content/PendingContent.kt	회원가입 대기 화면 컴포넌트 생성
feature/signup/src/main/res/drawable/	회원가입 완료 및 대기 일러스트 추가
feature/signup/src/main/res/values/strings.xml	회원가입 완료 및 대기 상태 문자열 리소스 추가

Assessment against linked issues

목표	해결 여부	설명
회원가입 Complete View 구현	✅
회원가입 Pending View 구현	✅

Possibly related PRs

• Featrue/#37 HeaderActionbar component #38: 헤더 컴포넌트 파라미터 수정
• Featrue/#36 signup step 1 2 #39: 회원가입 단계 enum 변경
• Featrue/#40 signup step 3 4 #41: 회원가입 프로세스 업데이트

Suggested labels

CodeRabbit

Suggested reviewers

• ashwon12

Poem

🐰 회원가입의 여정, 토끼가 노래해요
대기와 완료, 새로운 길을 열어요
버튼 하나에 희망을 담아
우리의 앱, 이제 시작이에요!
🌈✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jinukeu]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 7

🔭 Outside diff range comments (2)

feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpScreen.kt (2)

Line range hint 41-56: 회원가입 단계가 하드코딩되어 있습니다.

AnimatedContent의 targetState가 SignUpStep.Name으로 하드코딩되어 있어 실제 회원가입 플로우가 동작하지 않을 것 같습니다. 현재 단계를 추적하는 상태 관리가 필요해 보입니다.

+    var currentStep by remember { mutableStateOf(SignUpStep.Name) }
+
     AnimatedContent(
         modifier = Modifier.weight(1f),
-        targetState = SignUpStep.Name,
+        targetState = currentStep,
         label = "AnimatedContent",
     ) { targetState ->

---

Line range hint 65-69: 다음 단계로 이동하는 로직이 누락되었습니다.

버튼 클릭 시 다음 단계로 이동하는 로직이 구현되어 있지 않습니다. 각 단계별로 적절한 유효성 검사 후 다음 단계로 이동하는 로직이 필요합니다.

     YappSolidPrimaryButtonXLarge(
         modifier = Modifier
             .padding(horizontal = 20.dp)
             .fillMaxWidth(),
         text = stringResource(R.string.signup_screen_button_next),
-        onClick = {}
+        onClick = {
+            when (currentStep) {
+                SignUpStep.Name -> if (isNameValid) currentStep = SignUpStep.Email
+                SignUpStep.Email -> if (isEmailValid) currentStep = SignUpStep.Password
+                SignUpStep.Password -> if (isPasswordValid) currentStep = SignUpStep.Position
+                SignUpStep.Position -> if (isPositionValid) currentStep = SignUpStep.Pending
+                SignUpStep.Pending -> if (isPendingValid) currentStep = SignUpStep.Complete
+                SignUpStep.Complete -> { /* 회원가입 완료 처리 */ }
+            }
+        }
     )

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc0421e and d3344ed.

📒 Files selected for processing (8)

• core/designsystem/src/main/java/com/yapp/core/designsystem/component/header/YappHeaderActionbar.kt (1 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpScreen.kt (2 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/SignUpStep.kt (1 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/content/CompleteContent.kt (1 hunks)
• feature/signup/src/main/java/com/yapp/feature/signup/signup/content/PendingContent.kt (1 hunks)
• feature/signup/src/main/res/drawable/illust_signup_complete.xml (1 hunks)
• feature/signup/src/main/res/drawable/illust_signup_pending.xml (1 hunks)
• feature/signup/src/main/res/values/strings.xml (1 hunks)

🔇 Additional comments (5)

core/designsystem/src/main/java/com/yapp/core/designsystem/component/header/YappHeaderActionbar.kt (2)

63-65: 매개변수의 Nullable 처리가 적절히 구현되었습니다.

매개변수를 nullable로 변경하여 헤더의 유연성이 향상되었습니다.

---

72-82: null 체크가 적절히 구현되었습니다.

leftIcon이 null일 경우를 안전하게 처리하고 있습니다.

feature/signup/src/main/res/values/strings.xml (1)

38-41: 회원가입 상태에 대한 메시지가 명확하게 작성되었습니다.

완료와 대기 상태에 대한 메시지가 사용자 친화적으로 작성되었습니다. 특히 대기 상태에서 다음 단계(운영진 승인 요청)를 안내하는 것이 좋습니다.

feature/signup/src/main/res/drawable/illust_signup_pending.xml (1)

1-5: 벡터 드로어블의 크기가 적절히 설정되었습니다.

뷰포트와 크기가 명확하게 정의되어 있습니다.

feature/signup/src/main/res/drawable/illust_signup_complete.xml (1)

1-5: 벡터 드로어블의 크기가 적절히 설정되었습니다.

뷰포트와 크기가 명확하게 정의되어 있습니다.