Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YARG DLC source and icon #50

Closed
wants to merge 7 commits into from
Closed

Add YARG DLC source and icon #50

wants to merge 7 commits into from

Conversation

Frickitickitavi
Copy link
Contributor

Going to be needed soonish 😉

Copy link
Member

@kaduwaengertner kaduwaengertner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only remove the icon, we have a different DLC icon designed since day one that I can upload later

@Frickitickitavi
Copy link
Contributor Author

Removing the icon produces a warning because the source is referencing an nonexistent file. I've updated it to Generic, but honestly I wonder if it's worth doing this in advance if you're going to push an icon anyway

@Frickitickitavi
Copy link
Contributor Author

(that is to say, feel free to reject if you'd rather push the source and your own icon at the same time)

@Frickitickitavi
Copy link
Contributor Author

Closing this PR because I assume the source will get added alongside the proper icon.

(and I have other changes I want to make but this change is on master in my fork so I want it out of the way lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants