Fix venues shaders on OSX (again) #957
Conversation
There was a problem hiding this comment.
Hello, thanks for the PR!
Unfortunately, this is beginning to look like more of a hack than an actual fix to the cross-platform venue problem, which we would like to avoid. You mention that not all shader variants were exported. Do you think there's a more elegant way to get the shader variants without looking through all of the materials, removing the textures, and then exporting those?
Thanks!
| @@ -91,7 +91,7 @@ private async UniTaskVoid Start() | |||
| // Yarground comes with shaders for dx11/dx12/glcore/vulkan | |||
| // Metal shaders used on OSX come in this separate bundle | |||
| // Update our renderers to use them | |||
| var renderers = bg.GetComponentsInChildren<Renderer>(); | |||
There was a problem hiding this comment.
This is a fix that I found while testing. I've seen venues that have an object inactive in the beginning but then show it later. Passing true here will ensure we fixup all objects regardless if they are active in hierarchy or not
|
It looks like I may have broken something in latest update here and it still wouldn't work with all the shaders on the mac. I'll switch to draft for now and reopen when confirming |
|
Fixed and retested, exported bundles work with the current nightly (as they mostly should) |
Previously we were exporting shaders for OSX separately. Unfortunately that does not seem to guarantee that all shader variants were exported. To mitigate that we now export materials as well. However to avoid doubling of resulting yarground size we replace all textures with dummy on export. Loading side does not change
Previously we were exporting shaders for OSX separately. Unfortunately that does not guarantee that all shader variants were exported. To mitigate that we now export materials instead. However to avoid doubling of resulting yarground size we replace all textures with dummy on export.
On load we fixup all the shaders to pick up from osx-specific subbundle