Merge pull request #114 from Yelp/post_handler_hook_zipkin_span

add zipkin_span_context argument to post_handker_hook
Yelp · Oct 28, 2021 · 9b3bdae · 9b3bdae
2 parents f8d1916 + 584fb8c
commit 9b3bdae
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,3 +1,8 @@
+1.0.0 (2021-10-27)
+-------------------
+- The post_handler_hook api is changed to pass the zipkin_span context
+  so users can add more content to the span during post processing
+
 0.27.0 (2020-04-07)
 -------------------
 - Change tween ordering to be close to INGRESS rather than EXCVIEW

diff --git a/pyramid_zipkin/tween.py b/pyramid_zipkin/tween.py
@@ -196,7 +196,7 @@ def tween(request):
             )
 
             if zipkin_settings.post_handler_hook:
-                zipkin_settings.post_handler_hook(request, response)
+                zipkin_settings.post_handler_hook(request, response, zipkin_context)
 
             return response
 

diff --git a/tests/tween_test.py b/tests/tween_test.py
@@ -75,6 +75,7 @@ def test_zipkin_tween_post_handler_hook(
         mock_post_handler_hook.assert_called_once_with(
             dummy_request,
             dummy_response,
+            mock_span.return_value.__enter__.return_value,
         )