Skip to content

Commit

Permalink
Merge pull request #335 from Yoast/JRF/ghactions-run-against-php83
Browse files Browse the repository at this point in the history
GH Actions: enable linting and testing against PHP 8.3
  • Loading branch information
jrfnl authored Nov 20, 2023
2 parents c010070 + 1e8a0fe commit 0021f0d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
matrix:
# Lint against the highest/lowest supported versions of each PHP major.
# And also do a run against "nightly" (the current dev version of PHP).
php_version: ['7.2', '7.4', '8.0', '8.1', '8.2']
php_version: ['7.2', '7.4', '8.0', '8.2', '8.3']

name: "Lint: PHP ${{ matrix.php_version }}"

Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ jobs:

strategy:
matrix:
php_version: ['7.3', '7.4', '8.0', '8.1']
php_version: ['7.3', '7.4', '8.0', '8.1', '8.2']
coverage: [false]

# Run code coverage only on high/low PHP.
include:
- php_version: 7.2
coverage: true
- php_version: 8.2
- php_version: 8.3
coverage: true

name: "Unit Test: PHP ${{ matrix.php_version }}"
Expand Down Expand Up @@ -167,6 +167,12 @@ jobs:
- php_version: "8.2"
wp_version: "6.3"
multisite: true
coverage: false

# WP 6.4 is the earliest version which supports PHP 8.3.
- php_version: '8.3'
wp_version: '6.4'
multisite: true
coverage: true

name: "WP Test: PHP ${{ matrix.php_version }} | WP ${{ matrix.wp_version }}${{ matrix.multisite == true && ' (+ ms)' || '' }}"
Expand Down

0 comments on commit 0021f0d

Please sign in to comment.