Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ui placeholders for selecting publishing principles #20349

Merged
merged 24 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ const FormikPageSelectField = ( { name, id, className = "", ...props } ) => {
const { fetchPages } = useDispatchSettings();
const [ { value, ...field }, , { setTouched, setValue } ] = useField( { type: "select", name, id, ...props } );
const [ status, setStatus ] = useState( ASYNC_ACTION_STATUS.idle );
const [ initialPagesFound, setInitialPagesFound ] = useState( false );
const [ queriedPageIds, setQueriedPageIds ] = useState( [] );
thijsoo marked this conversation as resolved.
Show resolved Hide resolved
const canCreatePages = useSelectSettings( "selectPreference", [], "canCreatePages", false );
const createPageUrl = useSelectSettings( "selectPreference", [], "createPageUrl", "" );
Expand Down Expand Up @@ -77,8 +76,8 @@ const FormikPageSelectField = ( { name, id, className = "", ...props } ) => {
const handleQueryChange = useCallback( event => debouncedFetchPages( event.target.value ), [ debouncedFetchPages ] );

useEffect( () => {
setQueriedPageIds( map( pages, page => page.id ) );
}, [ pages, initialPagesFound ] );
setQueriedPageIds( map( pages, page => page.id ) );
}, [ pages ] );

return (
<AutocompleteField
Expand Down
20 changes: 15 additions & 5 deletions packages/js/src/settings/store/pages.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
import { createEntityAdapter, createSelector, createSlice } from "@reduxjs/toolkit";
import apiFetch from "@wordpress/api-fetch";
import { buildQueryString } from "@wordpress/url";
import { get, map, trim } from "lodash";
import { map, trim } from "lodash";
import { ASYNC_ACTION_NAMES, ASYNC_ACTION_STATUS } from "../constants";

const pagesAdapter = createEntityAdapter();

export const FETCH_PAGES_ACTION_NAME = "fetchPages";
// Global abort controller for this reducer to abort requests made by multiple selects.
let abortController;

/**
* @param {Object} queryData The query data.
Expand Down Expand Up @@ -82,7 +84,6 @@ export const pageSelectors = {
selectPageIds: pageAdapterSelectors.selectIds,
selectPageById: pageAdapterSelectors.selectById,
selectPages: pageAdapterSelectors.selectEntities,
selectPagesFetchStatus: state => get( state, "pages.status", {} ),
};
pageSelectors.selectPagesWith = createSelector(
[
Expand All @@ -106,10 +107,19 @@ export const pageActions = {
fetchPages,
};


export const pageControls = {
[ FETCH_PAGES_ACTION_NAME ]: async( { payload } ) => apiFetch( {
path: `/wp/v2/pages?${ buildQueryString( payload ) }`,
} ),
[ FETCH_PAGES_ACTION_NAME ]: async( { payload } ) => {
if ( abortController ) {
igorschoester marked this conversation as resolved.
Show resolved Hide resolved
abortController?.abort();
}

abortController = new AbortController();
await apiFetch( {
path: `/wp/v2/pages?${ buildQueryString( payload ) }`,
signal: abortController?.signal,
igorschoester marked this conversation as resolved.
Show resolved Hide resolved
} );
},
};

export default pagesSlice.reducer;