YoastCS: add more generic rules #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | -- | Yst Free | --
... except when there is inline HTML nested within the control structure body. Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | -- | Yst Free | -- Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | -- | Yst Free | -- Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | -- | Yst Free | -- Note: this rule was previously already "silently" enforced via clean-up sweeps.
... for multi-line concatenations. Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | -- | Yst Free | 90 Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | 54 | Yst Video | -- | Yst Premium | -- | Yst Free | -- Note: this rule was previously already "silently" enforced via clean-up sweeps.
... when the `$this` variable is not accessed. Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | -- | Yst Free | 2 Note: this rule was previously already "silently" enforced via clean-up sweeps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YoastCS rules: enforce lowercase PHP tags
Impact on Yoast packages:
YoastCS rules: disallow alternative control structure syntax
... except when there is inline HTML nested within the control structure body.
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: disallow the use of the logical and/or operators
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: forbid double negation
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: enforce consistent concatenation operator position
... for multi-line concatenations.
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: disallow implicit array creation
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: enforce closures to be static
... when the
$thisvariable is not accessed.Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
Related to #303