Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the buged config site #19

Merged
merged 15 commits into from
May 19, 2024
Merged

Conversation

Hemi03
Copy link
Contributor

@Hemi03 Hemi03 commented Mar 29, 2024

Problem

  • readonly and browsable totally broken
  • old settings were used, so it created new folders in the root dir
  • new directorys didn't get there configs
  • wrong service name for samba
  • "share" was named "shared" in the settings tags
  • old configs didn't get removed

Solution

  • fixed readonly and browsable
  • fix service name
  • update the share directory tag in install

WARNING

By fixing the share tag, the update needs a automatic migration for users, or it breaks the access to share folder if users use the config page.
If this pr dosnt go threw pleas remove the config page, its really broken.

Tests

I tested everything on my VM.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@Hemi03
Copy link
Contributor Author

Hemi03 commented Apr 1, 2024

fixes: #4

@ericgaspar ericgaspar changed the base branch from master to testing April 9, 2024 18:24
@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@yunohost-bot
Copy link
Contributor

📚 🪱
Test Badge

@Hemi03 Hemi03 mentioned this pull request Apr 17, 2024
2 tasks
@ericgaspar ericgaspar merged commit f8bef69 into YunoHost-Apps:testing May 19, 2024
@ericgaspar ericgaspar mentioned this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants