Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Item Location Fixes #35

Merged
merged 6 commits into from
Feb 4, 2024
Merged

WIP: Item Location Fixes #35

merged 6 commits into from
Feb 4, 2024

Conversation

PhlexPlexico
Copy link

@PhlexPlexico PhlexPlexico commented Feb 4, 2024

Patch Side:

  • Include fixes for deku trade quest in giving repeat progressive items.
  • Include gorman track fix for getting the mask and milk.
  • Fix for bottle refills and obtaining new bottles.
  • Bring back blue rupee item give back on default chests.
  • Fix HP Override for the Fish Lab HP
  • Adjust Keaton to use flags for green rupees instead of heart pieces to avoid collisions in searches.
  • Fix Oceanside Spiderhouse override
  • Fix camera reset on Zora Swimming and Goron Rolling
  • Dungeon resets will now keep free standing stray fairies removed, and keep doors that were previously unlocked open.
  • Banker no longer keeps giving rewards at 1k rupees
  • Swamp Manager now gives the proper rewards and will give fishing passes after.

App/Logic Side:

  • Adjust Fill Algorithm so Anju & Kafei Items only get placed on day one accessible locations
  • Add new item & item location for Gorons Lullaby Intro & adjust logic to require it for the full Lullaby
  • Fix Poe Hut HP override
  • Fix Pamela's Father Override
  • Fix IG Iron Knuckle Override
  • Add new room for the room between the grave entrance on day 2 and the iron knuckle room and adjust logic to fit requirements
  • Fix Scene on Inverted Stone Tower chests, also fixes incorrect overrides on Inverted Stone Tower Temple as they were sharing scene and flag values.
  • Add new logic check, if starting with Song of Healing the Deku Mask and Bomber's Notebook will now fill with junk as they are otherwise unaccessable.
  • Adjust requirements for Deku Butler Race to require Deku Princess to be returned.
  • Update Deku Princess requirements to need a bottle.
  • Add Oath to Order checks to the end of all dungeons as it is obtained after the first dungeon clear.
  • Adjust Ikana King requirements as only Mirror Shield works not Light Arrows.
  • Fix Starting Sword so the correct amount of progressive swords is added to the pool depending on which starting sword option is selected, (3 for None, 2 for Kokiri, 1 for Razor, 0 for Gilded)
  • Fix Starting Shield so the correct amount of Shields is added to the pool depending on which starting shield option is selected.
  • Update Giant's Mask Chest Flag to 0x00
  • Add in Keaton Check for Springtime Mountain Village

PhlexPlexico and others added 6 commits February 2, 2024 16:51
Update Pamela override.
- Adjust Fill Algorithm so Anju & Kafei Items only get placed on day one accessible locations
- Add new item & item location for Gorons Lullaby Intro & adjust logic to require it for the full Lullaby
- Fix Poe Hut HP override
- Fix Pamela's Father Override
- Fix IG Iron Knuckle Override
- Add new room for the room between the grave entrance on day 2 and the iron knuckle room and adjust logic to fit requirements
- Fix Scene on Inverted Stone Tower chests, also fixes incorrect overrides on Inverted Stone Tower Temple as they were sharing scene and flag values.
- Add new logic check, if starting with Song of Healing the Deku Mask and Bomber's Notebook will now fill with junk as they are otherwise unaccessable.
- Adjust requirements for Deku Butler Race to require Deku Princess to be returned.
- Update Deku Princess requirements to need a bottle.
- Add Oath to Order checks to the end of all dungeons as it is obtained after the first dungeon clear.
- Adjust Ikana King requirements as only Mirror Shield works not Light Arrows.
- Fix Starting Sword so the correct amount of progressive swords is added to the pool depending on which starting sword option is selected, (3 for None, 2 for Kokiri, 1 for Razor, 0 for Gilded)
- Fix Starting Shield so the correct amount of Shields is added to the pool depending on which starting shield option is selected.
Update Giant's Mask Chest Flag to 0x00
Update subrepo to bring in bottle override checks.

Update Keaton locations to use green rupee instead of heart piece to avoid collisions.
- Adds Mountain Village Keaton Quiz Check
@PhlexPlexico PhlexPlexico marked this pull request as ready for review February 4, 2024 18:48
@PhlexPlexico PhlexPlexico merged commit 0b9790f into main Feb 4, 2024
2 checks passed
@PhlexPlexico PhlexPlexico deleted the more-override-fixes branch February 4, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants