Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic updates #69

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Logic updates #69

merged 3 commits into from
Mar 8, 2024

Conversation

jcallen
Copy link

@jcallen jcallen commented Mar 6, 2024

  • Dampé doesn't give a bottle in the 3DS version, instead it's at the swamp archery
  • Update the logic around the Mystery Milk bottle -- ensure that the player can actually turn in the milk before assuming it can be used as an empty bottle

@Tacoman369
Copy link
Collaborator

Everything looks good to me except in Item_pool.cpp in the PlaceVanillaMainInventory function you have Empty_Bottle1 on the Beaver Race location when Empty_Bottle1 is defined as the ArcheryBottle not the BeaverRaceBottle. Just switch the two and its good to go in :)

jcallen added 3 commits March 7, 2024 15:23
It's found at the Boat Archery instead. Rename variables accordingly,
and fix the vanilla fill.
Adjust the logic to require the Troupe Leader's Mask.  May need more
tweaks for entrance shuffle.
Make it more likely to work with entrance shuffle.
@jcallen
Copy link
Author

jcallen commented Mar 7, 2024

There was already an issue with confusing EMPTY_BOTTLE1 and EMPTY_BOTTLE2, I had just made it worse. I've force-pushed an updated branch that should be consistent everywhere (making the "earlier" archery one empty bottle 1 and the "later" beaver race one empty bottle 2 everywhere)

@Tacoman369 Tacoman369 merged commit 856bf79 into Z3DR:main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants