fix: consider only dimensions with size >1 for plane-coordinate #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptahmose
changed the title
soyers
approved these changes
Jul 23, 2024
soyers
approved these changes
Jul 23, 2024
|
Abandoning in favor of #28 due to changes in infrastructure. |
FelixS90
added a commit
that referenced
this pull request
Aug 6, 2024
[x] I followed the [How to structure your PR](https://github.com/ZEISS/pylibczirw/blob/main/CONTRIBUTING.md#creating-a-pr). [ ] Based on [Commit Parsing](https://python-semantic-release.readthedocs.io/en/latest/commit-parsing.html): In case a new **major** release will be created (because the body or footer begins with 'BREAKING CHANGE:'), I created a new [Jupyter notebook with a matching version](https://github.com/ZEISS/pylibczirw/tree/main/doc/jupyter_notebooks). [ ] Based on [Commit Parsing](https://python-semantic-release.readthedocs.io/en/latest/commit-parsing.html): In case a new **minor/patch** release will be created (because PR title begins with 'feat'/('fix' or 'perf')), I optionally created a new [Jupyter notebook with a matching version](https://github.com/ZEISS/pylibczirw/tree/main/doc/jupyter_notebooks). [ ] In case of API changes, I updated [API.md](https://github.com/ZEISS/pylibczirw/blob/main/API.md). Re-write of #16 due to changes in infrastructure. Fixes #10 --------- Co-authored-by: Soyer, Sebastian <[email protected]> Co-authored-by: soyers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: consider only dimensions with size >1 for plane-coordinate
[x] I followed the How to structure your PR.
[ ] Based on Commit Parsing: In case a new major release will be created (because the body or footer begins with 'BREAKING CHANGE:'), I created a new Jupyter notebook with a matching version.
[ ] Based on Commit Parsing: In case a new minor/patch release will be created (because PR title begins with 'feat'/('fix' or 'perf')), I optionally created a new Jupyter notebook with a matching version.
[ ] In case of API changes, I updated API.md.
Summary of the change(s) and which issue(s) is/are fixed
This is a proposal to address the issue discussed in #10 . To be clear - it is more an side-effect that this change seems to fix the problem discussed there. However - I cannot see any adverse effects from this proposal, so the line of reasoning is: why not change this and as an added benefit, it will make this case work as well.
The root cause (for the problem with #10) I see as "being a malformed CZI".
Relevant motivation and context
Dependencies required for this change
Fixes #10