Copy attachments from source file to output file #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptahmose
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
I am thinking about
- Whether this should be an (i.e. a new command-line switch controlling if we do this copying) - but I don't think that's necessary.
- Whether we should blindly copy all attachments (or only specific ones) - this is of course difficult to answer, and I am fine with it as is. What I wonder about - what about the thumbnail? Copying this is arguably wrong, but maybe better than not having one at all.
Please consider my suggestions - esp. the one for CziSlicesWriterTbb::AddAttachment.
Don't forget to update the version here - this should be 0.5.0 (I'd see this as a new feature, not as a bug-fix). And please add an entry in the version-history.
ptahmose
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.