Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve layout of bgs-hero-overview #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve layout of bgs-hero-overview #195

wants to merge 2 commits into from
+51 −57

Conversation

piedpiper358
Copy link
Contributor

What was done:

  • Align components evenly
  • Enlarge hero portrait
  • Increase achievements size

Before:

2022-09-06_16-04-27

After:

2022-09-06_15-16-22

@sebastientromp
Copy link
Contributor

Could you also post a screenshot with the window at its minimum size?

@piedpiper358
Copy link
Contributor Author

piedpiper358 commented Sep 7, 2022 •
edited
Loading

We can slightly increase margins around the hero name. Should I do it?

2022-09-07_14-15-28

@sebastientromp
Copy link
Contributor

Yeah probably

@piedpiper358
Copy link
Contributor Author

2022-09-16_19-26-06

@piedpiper358 piedpiper358 removed their assignment Oct 24, 2022
@sebastientromp
Copy link
Contributor

Because you are replacing a few values with vw units, could you post a couple of screenshots at different window sizes to make sure that nothing breaks?

@sebastientromp sebastientromp force-pushed the master branch 3 times, most recently from 159c76c to ef452e5 Compare December 11, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piedpiper358 piedpiper358

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piedpiper358 @sebastientromp