Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReceiveCardInHandParser for Mindrender Illucia #330

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

barrinjo
Copy link

untested changes for updating mindrender illucia

@barrinjo barrinjo closed this Oct 13, 2023
@barrinjo barrinjo reopened this Oct 13, 2023
@barrinjo barrinjo changed the title Illucia Updates to Mindrender Illucia Event Parser Oct 13, 2023
@barrinjo barrinjo changed the title Updates to Mindrender Illucia Event Parser Update ReceiveCardInHandParser for Mindrender Illucia Oct 13, 2023
@barrinjo
Copy link
Author

barrinjo commented Oct 13, 2023

With these changes, Mindrender Illucia will update the opponent hand to include known cards.
No changes to behavior when opponent plays Illucia.

BEFORE:
before

AFTER:
after

@sebastientromp
Copy link
Contributor

At a glance, this looks good.
I can see there is a mindrender-illucia-parser file, but I think it was removed after illucia was patched.
Do you think you could implement this custom behavior in a new parser (you could reuse that one) to try and avoid adding too much custom logic in the "receive-card-in-hand" one?

@sebastientromp sebastientromp force-pushed the master branch 3 times, most recently from 159c76c to ef452e5 Compare December 11, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants