Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karazhan: Update timers #238

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −8
Open

Karazhan: Update timers #238

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88715c4
Karazhan: Update timers
ForestJ316 Jan 12, 2025
d789a8b
Maiden of Virtue: Update Repentance timer
ForestJ316 Jan 15, 2025
27debc5
Maiden of Virtue: Update revision
ForestJ316 Jan 15, 2025
f173826
Update MaidenOfVirtue.lua
ForestJ316 Jan 15, 2025
1074a0c
Netherspite: Bump revision
ForestJ316 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DBM-Karazhan/MaidenOfVirtue.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
local mod = DBM:NewMod("Maiden", "DBM-Karazhan")
local L = mod:GetLocalizedStrings()

mod:SetRevision("20220518110528")
mod:SetRevision("20250115214605")
mod:SetCreatureID(16457)

mod:SetModelID(16198)
Expand All @@ -22,7 +22,7 @@ local warningHolyFire = mod:NewTargetNoFilterAnnounce(29522, 2)
--local specWarnHolyFire = mod:NewSpecialWarningMoveAway(29522, nil, nil, nil, 1, 2)

local timerRepentance = mod:NewBuffActiveTimer(12.6, 29511, nil, nil, nil, 2)
local timerRepentanceCD = mod:NewCDTimer(29.1, 29511, nil, nil, nil, 6)--29.1-49
local timerRepentanceCD = mod:NewNextTimer(33, 29511, nil, nil, nil, 6)
local timerHolyFire = mod:NewTargetTimer(12, 29522, nil, nil, nil, 5, nil, DBM_COMMON_L.MAGIC_ICON)

mod:AddRangeFrameOption(10, 29522)
Expand All @@ -32,7 +32,7 @@ function mod:OnCombatStart(delay)
if self.Options.RangeFrame then
DBM.RangeCheck:Show(10)
end
DBM:AddMsg("Repentance timer is not broken. This is an ability that has a 29 second minimum cooldown window, but after coming off CD can be delayed up to 20 seconds on when it's cast. Basically it's a 29-49sec window. DBM shows timer for the start of that window, but cannot control whether or not the boss casts it at 29, 39, or 49. Use this knowledge to inform you of when the ability can NOT be cast, not when it will be.")
--DBM:AddMsg("Repentance timer is not broken. This is an ability that has a 29 second minimum cooldown window, but after coming off CD can be delayed up to 20 seconds on when it's cast. Basically it's a 29-49sec window. DBM shows timer for the start of that window, but cannot control whether or not the boss casts it at 29, 39, or 49. Use this knowledge to inform you of when the ability can NOT be cast, not when it will be.")
end

function mod:OnCombatEnd()
Expand Down
8 changes: 4 additions & 4 deletions DBM-Karazhan/Netherspite.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ mod:RegisterEventsInCombat(
"CHAT_MSG_RAID_BOSS_EMOTE"
)

local warningPortal = mod:NewAnnounce("warningPortal", 1, "135743")
local warningBanish = mod:NewAnnounce("warningBanish", 1, "136135")
local warningPortal = mod:NewAnnounce("warningPortal", 1, "Interface\\Icons\\Spell_Arcane_PortalIronforge")
local warningBanish = mod:NewAnnounce("warningBanish", 1, "Interface\\Icons\\Spell_Shadow_Cripple")
local warningBreathCast = mod:NewCastAnnounce(38523, 2)
local warningVoid = mod:NewSpellAnnounce(37063, 4)

local specWarnVoid = mod:NewSpecialWarningGTFO(30533, nil, nil, nil, 1, 6)

local timerPortalPhase = mod:NewTimer(61.5, "timerPortalPhase", "135743", nil, nil, 6)
local timerBanishPhase = mod:NewTimer(30, "timerBanishPhase", "136135", nil, nil, 6)
local timerPortalPhase = mod:NewTimer(61.5, "timerPortalPhase", "Interface\\Icons\\Spell_Arcane_PortalIronforge", nil, nil, 6)
local timerBanishPhase = mod:NewTimer(30, "timerBanishPhase", "Interface\\Icons\\Spell_Shadow_Cripple", nil, nil, 6)
local timerBreathCast = mod:NewCastTimer(2.5, 38523, nil, nil, nil, 3)

local berserkTimer = mod:NewBerserkTimer(540)
Expand Down
Loading