Fix for issue where statuscode 255 was being returned even for succesful transactions #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sful transactions - `receipt.accepted==Some(false)` is no ignored, and if `receipt.success==true` the transaction is reported dispatched
|
Bencher Report| Branch | max/bugfix/GetTransactionStatus_wrong_status |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9.44 (+2.69%) | 10.33 (91.35%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,958.60 (-0.15%) | 2,285.17 (85.71%) |
saeed-zil
approved these changes
Jan 13, 2025
|
Looks like the test failure is actually in main, just messaged @JamesHinshelwood about it because it seems to come from #2130 |
JamesHinshelwood
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
receipt.accepted==Some(false)is now ignored, and ifreceipt.success==truethe transaction is reported dispatched@saeed-zil I noticed you already assigned yourself the associated issue after I pushed this, my bad.
Please feel free to reject it if's likely to cause a conflict with something you've already got in the works :)