Get Proof implementation #2128
Open
Get Proof implementation #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 1547-implement-state-proof |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9.37 (+2.22%) | 10.34 (90.61%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,952.90 (-1.01%) | 2,310.97 (84.51%) |
| return Ok(Proof::default()); | ||
| }; | ||
|
|
||
| // get_proof() requires &mut so clone state and don't mutate the origin |
There was a problem hiding this comment.
Why not make this &mut self instead? You already make a clone of it in the API implementation (by calling .at_root).
| let storage_proofs = { | ||
| let mut storage_proofs = Vec::new(); | ||
| for key in storage_keys { | ||
| let key = Self::account_storage_key(address, *key); |
There was a problem hiding this comment.
@DrZoltanFazekas Are we happy that this exposes our trie encoding as part of our external API (and thus makes it hard to ever change it)?
I ask because I don't think we are encoding things into the trie the same way as Ethereum does and thus there's no guarantee that what we're doing is sensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces eth_getProof implementation.