Update VideoClip.py #2161
Closed
Update VideoClip.py #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where fps=None due to changes in python decorators
bjackson
reviewed
Jul 10, 2024
| @@ -362,6 +362,9 @@ def write_videofile( | |||
| name + Clip._TEMP_FILES_PREFIX + "wvf_snd.%s" % audio_ext, | |||
| ) | |||
|
|
|||
| if fps is None: | |||
| fps = fps.self | |||
There was a problem hiding this comment.
Should it be this?
Suggested change
| fps = fps.self | |
| fps = self.fps |
|
Thank you for your contributions and for reporting issues in this repository. With the release of v2, which introduces significant changes to the codebase and API, we’ve reviewed the backlog of open PRs and issues. Due to the length of the backlog and the likelihood that many of these are either fixed or no longer applicable, we’ve made the decision to close all previous PRs and issues. If you believe that any of these are still relevant to the current version or if you'd like to reopen a related discussion, please feel free to create a new issue or pull request, referencing the old one. Thank you for your understanding and continued support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where fps=None due to changes in python decorators
The bug arises when write_video is used. The ffmpeg's write operation fails due to fps=None.