Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2286 on TimeMirror and TimeSymmetrize #2328

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

OsaAjani
Copy link
Collaborator

Reversing a clip by slicing was removing last second of a clip, as described by #2286, this was due to an error in the implementation of Clip.__getitem__() where we was subtracting 1 instead of 1/self.fps. This was not showing in unit test because unit test was using a 1FPS video.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@OsaAjani OsaAjani merged commit e8f217e into Zulko:master Jan 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant