Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ’© ν…ŒμŠ€νŠΈ ν’€λ¦¬ν€˜μŠ€νŠΈ #24

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

πŸ’© ν…ŒμŠ€νŠΈ ν’€λ¦¬ν€˜μŠ€νŠΈ #24

wants to merge 1 commit into from

Conversation

Bori-github
Copy link
Collaborator

@Bori-github Bori-github commented Feb 22, 2023 •
edited
Loading

πŸ”— μ—°κ΄€λœ 이슈

  • close #issue_number

πŸ—’ μž‘μ—… λͺ©λ‘

  • λ“œλž˜ν”„νŠΈ ν’€λ¦¬ν€˜μŠ€νŠΈ ν…ŒμŠ€νŠΈ

🧐 PR Point

  • κΉƒ ν’€λ¦¬ν€˜μŠ€νŠΈλ‚˜ 컀밋 ν…ŒμŠ€νŠΈλ₯Ό μœ„ν•œ ν’€λ¦¬ν€˜μŠ€νŠΈ μž…λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ 해보고 μ‹Άμ€κ²Œ μžˆλ‹€λ©΄ ν•΄λ‹Ή ν’€λ¦¬ν€˜μŠ€νŠΈμ—μ„œ μ§„ν–‰ν•΄μ£Όμ„Έμš”.

πŸ’₯ Trouble Shooting

  • ν•΄λ‹Ή μž‘μ—…μ„ ν•˜λ˜ 쀑 λ°œμƒν–ˆλ˜ λ¬Έμ œμ— λŒ€ν•΄ μž‘μ„±ν•΄μ£Όμ„Έμš”.

πŸ“Έ μŠ€ν¬λ¦°μƒ· / ν”Όκ·Έλ§ˆ 링크

  • λ‚΄μš©μ„ μž…λ ₯ν•΄μ£Όμ„Έμš”.

πŸ“š μ°Έκ³ 

  • μ°Έκ³ ν•œ λ‚΄μš© λ˜λŠ” 링크λ₯Ό μž…λ ₯ν•΄μ£Όμ„Έμš”.

βœ… PR Submit μ „ 체크리슀트

  • [] Merge ν•˜λŠ” λΈŒλžœμΉ˜λŠ” main λΈŒλžœμΉ˜κ°€ μ•„λ‹™λ‹ˆλ‹€.
  • [] μ½”λ“œμ— ν¬λ¦¬ν‹°μ»¬ν•œ error λ˜λŠ” warning이 μ‘΄μž¬ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
  • [] λΆˆν•„μš”ν•œ console이 μ‘΄μž¬ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

@Bori-github Bori-github self-assigned this Feb 22, 2023
@Bori-github Bori-github marked this pull request as ready for review February 22, 2023 14:07
@Bori-github Bori-github changed the title πŸ’© test commit πŸ’© ν…ŒμŠ€νŠΈ ν’€λ¦¬ν€˜μŠ€νŠΈ Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choisung2 choisung2 Awaiting requested review from choisung2

@yws1502 yws1502 Awaiting requested review from yws1502 yws1502 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Bori-github Bori-github

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bori-github