Improvements to knnshap parallelization #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janosg This is a minor PR, tagging you in case you are curious and have time in some distant future :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR distributes test samples in the parallelization of KNN shapley across workers, instead of processing test points one by one. This reduces the memory cost and the number of processes started.
Changes
Checklist
Updated Documentation (if necessary)-> There's no documentation for the newvaluationmodule yetIf notebooks were added/changed, added boilerplate cells are tagged with"tags": ["hide"]or"tags": ["hide-input"]