Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): correct run.sh path in simple Dockerfile #1911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crufter
Copy link

@crufter crufter commented Jan 27, 2025

I think the current version of the Dockerfile assumes a docker context of project root, but I don't see why that should be the case, since the line

RUN pip install llama-cpp-python --verbose;

clearly indicates that the project source code is not needed?
Seems like a waste of resources to use project root as the context?

This is also inline with the other Dockerfiles such as Open Llama one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant