Speed up counsel-yank-pop on large kill-ring #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl-delete-duplicates rapidly slows down on large inputs. Alternatives to the approach in this patch: - Avoid deduplication beyond a certain threshold. - Deduplicate only when kill-do-not-save-duplicates is non-nil. - Make equality test customizable. - Ignore text properties by default. * counsel.el (counsel--idx-of): New macro. (counsel--yank-pop-position): Use it. (counsel-string-non-blank-p): Simplify. (counsel--equal-w-props, counsel--yank-pop-filter): New functions for replicating delete-dups under equal-including-properties (#3045). (counsel--yank-pop-kills): Use counsel--yank-pop-filter. (counsel-yank-pop-action-remove): Prefer setq over set. * ivy-test.el (counsel-string-non-blank-p, counsel--equal-w-props) (counsel--yank-pop-filter): New tests. Fixes #3040.
basil-conto
force-pushed
the
blc/eq-incl-props
branch
from
e25b1a9 to
d8dace9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl-delete-duplicatesrapidly slows down on large inputs. Alternatives to the approach in this patch:kill-do-not-save-duplicatesis non-nil.Fixes #3040.