Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Complexity documentation with gotcha's and pagination example #1150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SophisticaSean
Copy link

@SophisticaSean SophisticaSean commented Jan 31, 2022

Hello! I recently spent two weeks diagnosing and fixing complexity analysis in my graphql schema to prevent Denial of Service attacks against our graphql server.

We discussed this issue in absinthe relay here: absinthe-graphql/absinthe_relay#192

@benwilson512 Recommended I add this to the complexity documenation so I distilled most of my findings down and into the graphql complexity documentation to try to help future users of this wonderful library.

Let me know if I should change anything or if we'd prefer this somewhere else! Thanks bunches!

P.S. There may be more specific work to do on DoS mitigation in this library and I would love to discuss this further if anyone is interested. I would love to see some automatic DoS mitigation techniques on documents that are too complex or taking too long to resolve. We recently engaged with a security pentesting team to test our production absinthe application and it does seem like it's pretty easy to implement a schema vulnerable to DoS attacks and it doesn't seem like absinthe ships with any mitigation techniques currently! :)

View the updated markdown here: https://github.com/absinthe-graphql/absinthe/blob/4497bd2066bc41000b519a2b8c538ae043a92408/guides/complexity-analysis.md

@SophisticaSean
Copy link
Author

Looks like mix format caught a couple areas to format. Let me know if we want to drop those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants