Check absinthe dependent libraries on CI runs #1322
Conversation
|
Oh this reminds me, we should update the Elixir versions we test against, particularly with 1.17 out. We should only do 1.15, 1.16, and 1.17 |
.github/workflows/elixir.yml
Outdated
| - elixir: "1.15" | ||
| otp: "26" | ||
| format: true | ||
| - '24' |
There was a problem hiding this comment.
I'm fine dropping this one at this point.
|
Is it failing because of the change/fix in the |
|
@maartenvanvliet thanks for that! I've been trying to figure it out. Especially since it passes locally with Elixir 1.17 and OTP 27, though I'm on a mac. I'll look and see if that's the issue. |
|
I guess I wasn't running those versions locally after all. Updating, I can now see the failed tests locally. I'll see if I should update the test or the jaro distance threshold. |
* Update elixir versions in CI to test 1.15, 1.16, and 1.17
* Update OTP version in CI to test 25, 26, and 27
* Update ubuntu version to 24.04
* Lower jaro_distance threshold slightly
* Remove else part of with expression in generate_schema. Dialyzer
saw that Absinthe.Schema.introspect will only return
{:error, String.t()} if there is an error
bryanjos
force-pushed
the
bryanj/check_dependents
branch
from
7f97913 to
bba72db
Compare
|
@benwilson512 I think this is good to go now! Aside from the CI changes, I lowered the jaro_distance slightly (thanks again @maartenvanvliet!), and fixed an issue dialyzer found. |
No problem, saw the CI error and vaguely recalled the change in elixir a few months back |
This PR adds a GitHub action to check the libraries that depend on Absinthe to ensure they still work with the changes added in PRs.