Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: update VectorData #140

Merged
merged 3 commits into from
Jun 20, 2024
Merged

DEP: update VectorData #140

merged 3 commits into from
Jun 20, 2024

Conversation

aburrell
Copy link
Owner

@aburrell aburrell commented Jun 20, 2024

Description

Removes deprecated attributes, kwargs, and methods from the VectorData class, addressing #133. Also updated changelog for PR #139.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)

How Has This Been Tested?

Ran unit tests locally.

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My commits are formatted appropriately (following the SciPy/NumPy style)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

aburrell added 3 commits June 20, 2024 12:13
Removed the deprecated attributes, methods, and kwargs in the VectorData class.
Removed the tests for the deprecated portions of the VectorData class.
Update the changelog with new aspects of this pull request and portions of the previous pull request.
@aburrell aburrell added this to the v0.5.0 milestone Jun 20, 2024
@aburrell aburrell linked an issue Jun 20, 2024 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

coverage: 99.766%. first build
when pulling 8c46c93 on dep_vector
into 48d4654 on develop.

@aburrell aburrell merged commit 728bfcb into develop Jun 20, 2024
79 checks passed
@aburrell aburrell deleted the dep_vector branch June 20, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: remove support for deprected kwargs in VectorData
2 participants