Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelsim test #82

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

William-An
Copy link

Sanity test with Accel-Sim whenever GPGPU-Sim got changed. Right now just using rodinia-2.0 and QV100-SASS config. Making sure cases like #accel-sim/accel-sim-framework#353 got found before merging into mainstream.

@William-An William-An requested review from a team and LAhmos and removed request for a team January 10, 2025 23:58
@William-An
Copy link
Author

The new test should pass after #81 is merged.

@William-An
Copy link
Author

Another solution is to trigger the accel-sim github action whenever there is a push to the gpgpu-sim side so we can reuse the more comprehensive tests from the accel-sim side. A sample case might be:

  1. GPGPU-Sim sends a "repo dispatch" event to Accel-sim's github action script containing the specific gpgpu-sim repo to be tested on
  2. After tests were completed, accel-sim dispatch another event back to GPGPU-Sim notifying its status (which tests failed)

Some refs that might be helpful:

  1. https://github.com/marketplace/actions/repository-dispatch
  2. https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#create-a-repository-dispatch-event

@JRPan
Copy link

JRPan commented Jan 15, 2025

Yea I thought about this. Too much effort so I gave up. And we probably should merge some of the test.

@JRPan
Copy link

JRPan commented Jan 15, 2025

feel free to try it out if you want :). I can give you the token if needed

@LAhmos
Copy link

LAhmos commented Jan 21, 2025

@William-An any tips on how to review this?

@William-An
Copy link
Author

If the test script short-tests-accelsim.sh looks good to you then this should be okay. The github action script will run the test script on every push to test against accel-sim dev branch.

Copy link

@LAhmos LAhmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants