Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytorch example submodule #27

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

cesar-avalos3
Copy link

Simple PR to include the Pytorch Examples (https://github.com/pytorch/examples) repo, mainly replacing the outdated cuDNN MNIST samples.

@tgrogers
Copy link
Contributor

Cool.
Can you add a target to the main makefile for the examples? Or is there nothing to be built at all?

@cesar-avalos3
Copy link
Author

There's nothing to build, these are just scripts. I could remove the old cuDNN MNIST examples in this PR, so the current build error goes away.

@tgrogers
Copy link
Contributor

OK - I will merge this @Zhaoyu-Jin is working on cleaning up the makefile. mlperf is also broken.

@tgrogers tgrogers self-requested a review January 25, 2025 16:52
Copy link
Contributor

@tgrogers tgrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tgrogers tgrogers merged commit 81af207 into accel-sim:dev Jan 25, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants