Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/standalone-browser-versions-of-all-libaries #774

Conversation

Shyam-Raghuwanshi
Copy link

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • [] Extend the documentation, if necessary
  • Merging to main from fork:branchname

@mttrbrts
Copy link
Member

Thanks @Shyam-Raghuwanshi .

@DianaLease @jamieshorten please review.

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question inline. Also, why is this only needed in these two packages and not concerto-core? Could you add a description with more info to your PR? The proposed solution in the issue didn't seem to involve changing the webpack configs. Thanks!

return config;
};

// Rest of the webpack configuration
module.exports = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this just going to override the definition on line 22? Should you instead by calling the override function here like you did in concerto-util package?

@mttrbrts
Copy link
Member

Closing as stale

@mttrbrts mttrbrts closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants