Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Analytics (Google and Fullstory) #227

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Add Analytics (Google and Fullstory) #227

merged 4 commits into from
Mar 28, 2022

Conversation

trulyronak
Copy link
Member

@trulyronak trulyronak commented Mar 27, 2022

Description

In preparation for Spring Kickoff, this PR adds Google Analytics and Fullstory Analytics to the entire site.

Changes

  • Adds .env.example file so we can keep track of required env vars for development
  • Adds Google Analytics helper functions (we can add more custom analytics events in the future using this, to track everything) (following https://mariestarck.com/add-google-analytics-to-your-next-js-application-in-5-easy-steps/)
  • Fixed SEO bug where the title wasn't being set in the browser title
  • mild reorganization of existing utils.ts to be in a utils/ folder
  • Adds FullStory analytics so we can see where users run into issues / identify pain points with the main website

closes #179

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Logistical Change (something about code process / a readme change / documentation update)
  • CI Change (relating to deployment / continuous integration)
  • Something Else

How Has This Been Tested?

  • Tested on Localhost
  • Tested on Deployed Preview

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code as needed, particularly in hard-to-understand areas
  • My changes generate no new warnings (if they do, please explain why)

@vercel
Copy link

vercel bot commented Mar 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/acmucsd/main-website/7zYtPL5p2HyS286NhvMK44WqU41s
✅ Preview: https://main-website-git-ronak-add-analytics-acmucsd.vercel.app

@trulyronak trulyronak requested a review from farisashai March 27, 2022 20:18
@trulyronak trulyronak changed the title Add Google Analyrics Add Analytics (Google and Fullstory) Mar 27, 2022
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good overall! left a few nitpicks and ideas we can tackle in separate PRs

src/utils/general.ts Outdated Show resolved Hide resolved
src/components/SEO/index.tsx Show resolved Hide resolved
pages/_document.tsx Show resolved Hide resolved
pages/_document.tsx Outdated Show resolved Hide resolved
pages/_app.tsx Show resolved Hide resolved
pages/_app.tsx Show resolved Hide resolved
.env.example Show resolved Hide resolved
src/utils/analytics.ts Show resolved Hide resolved
Copy link
Member

@StormFireFox1 StormFireFox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added comments on Faris' nits, but overall could be merged.

@trulyronak trulyronak requested a review from farisashai March 28, 2022 05:42
@trulyronak trulyronak merged commit 61629e5 into main Mar 28, 2022
@trulyronak trulyronak deleted the ronak/add-analytics branch March 28, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add analytics
3 participants