Setup prettier and pre-commit hooks #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mikelehen
approved these changes
Dec 11, 2022
package.json
Outdated
| @@ -6,7 +6,12 @@ | |||
| "scripts": { | |||
| "develop": "webpack-dev-server --mode development", | |||
| "build": "webpack --mode production", | |||
| "build:watch": "webpack --watch --mode production" | |||
| "build:watch": "webpack --watch --mode production", | |||
| "prettier:write": "yarn prettier --write .", | |||
There was a problem hiding this comment.
Not a big deal, but should this include --ignore-unknown to match the lint-staged rule? I'm not 100% sure if it matters though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16 - Setup prettier, eslint and pre-commit hooks.
This PR only configures Prettier and Husky (pre-commit):
This commit is just running prettier on the codebase and fixing a few things.
Not sure if we want to add some custom prettier rules, but this is a start!