Tweak share-image dimensions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
smcclure17
changed the title
mikelehen
approved these changes
Feb 6, 2023
| /** | ||
| * Container used to create correct dimensions for preview images. | ||
| * Wrap the entirety of the share page content in this container and | ||
| * add the className "screenshot" to this element. | ||
| */ | ||
| export const ScreenshotWrapper = styled(Box)` | ||
| margin: 100px auto; | ||
| width: 1200px; | ||
| height: 630px; |
There was a problem hiding this comment.
Not a huge deal, but I think 1200x630 was supposed to be the "ideal" size for Facebook/twitter/etc. to avoid extra scaling, etc. So ideally I think we'd keep the size at 1200x630 and adjust the content to fill the space. Is that doable? Probably not worth putting much time into if it's not straightforward though.
There was a problem hiding this comment.
yeah, that makes sense--my initial hope was to not change the screenshot image component, but I think it makes most sense to update that content. I've made those changes in 33ee289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #30: Update the size of to match the width of share image screens to remove whitespace from screenshots. Some drive-by removals of unneeded stuff
Before:
After: