ref: update detray to v0.88.0 #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-update-detray
branch
from
6ae68e4 to
077cc64
Compare
beomki-yeo
reviewed
Feb 4, 2025
extern/detray/CMakeLists.txt
Outdated
| @@ -13,13 +13,13 @@ message( STATUS "Building Detray as part of the TRACCC project" ) | |||
|
|
|||
| # Declare where to get Detray from. | |||
| set( TRACCC_DETRAY_SOURCE | |||
| "URL;https://github.com/acts-project/detray/archive/refs/tags/v0.87.0.tar.gz;URL_MD5;0e30107edebfd41fbb3fc1974f665ea9" | |||
| "GIT_REPOSITORY;https://github.com/niermann999/detray;GIT_TAG;ref-algebra-detail" | |||
There was a problem hiding this comment.
Not really. I would like to include that branch in the new detray version
There was a problem hiding this comment.
So it's a draft PR, right...? Because of course we won't merge in this exact code. 🤔 Even a specific hash of your fork would be very iffy. But a branch name is of course absolutely a no-go.
There was a problem hiding this comment.
Sorry, I unmarked the draft, because it would otherwise not trigger the CUDA CI, which is what I am trying to fix on this detray branch
niermann999
force-pushed
the
ref-update-detray
branch
from
715efb8 to
e680a64
Compare
niermann999
force-pushed
the
ref-update-detray
branch
9 times, most recently
from
04d128e to
a492f7d
Compare
niermann999
force-pushed
the
ref-update-detray
branch
from
a492f7d to
ef634a9
Compare
niermann999
force-pushed
the
ref-update-detray
branch
from
ef634a9 to
02b3b41
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the new detray version. I also made sure that the traccc custom scalar type is handed through to detray, so that it will be built in double precision when required.