Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'SEB Kort Bank AB' credit card support #325

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

walleb
Copy link
Contributor

@walleb walleb commented Mar 20, 2024

Add custom bank adapter for 'SEB Kort Bank AB' to properly sync credit card transactions.

@walleb walleb marked this pull request as draft March 21, 2024 05:39
@MatissJanis
Copy link
Member

👋 Just checking if you're still working here or if this is ready for review. The PR is in "draft".

@walleb
Copy link
Contributor Author

walleb commented Mar 21, 2024

Yes, still working on it. I put it into "draft" as a realized that I need to verify the balance calculation. I suspect that it now shows a positive amount when it should be negative. Tricky to get it right for credit card accounts...

@walleb
Copy link
Contributor Author

walleb commented Mar 23, 2024

Balance calculation should be OK now for total, cleared and uncleared balances. It works properly when booking a payment of credit card bill with payee as one of the other accounts.

@walleb walleb marked this pull request as ready for review March 23, 2024 07:10
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MatissJanis MatissJanis merged commit bf40410 into actualbudget:master Mar 23, 2024
6 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review ✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully labels Mar 23, 2024
MMichotte pushed a commit to MMichotte/actual-server that referenced this pull request Sep 9, 2024
* feat: add 'SEB Kort Bank AB' credit card support

* add: release notes for actualbudget#325

* Calculate balance correctly for SEB Kort credit cards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants