Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update bank-factory.js and add Deutsche Kreditbank AG (DKB) (DKB_BYLADEM1) to the 90-days sync limited list #528

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

zenminimalist
Copy link
Contributor

@zenminimalist zenminimalist commented Dec 21, 2024


category: Enhancements
authors: [zenminimalist]

Update bank-factory.js and add Deutsche Kreditbank AG (DKB) (DKB_BYLADEM1) to the 90-days sync limited list

According to Gocardless's own coverage (https://docs.google.com/spreadsheets/d/1EZ5n7QDGaRIot5M86dwqd5UFSGEDTeTRzEq3D9uEDkM/edit?gid=976380583#gid=976380583), DKB bank supports up to 365 days of transaction and most other money apps pull in this amount automatically.
@actual-github-bot actual-github-bot bot changed the title Update bank-factory.js [WIP] Update bank-factory.js Dec 21, 2024
@zenminimalist zenminimalist changed the title [WIP] Update bank-factory.js [WIP] Update bank-factory.js and add Deutsche Kreditbank AG (DKB) (DKB_BYLADEM1) to the 90-days sync limited list Dec 21, 2024
Copy link

@joshelboy joshelboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the code clean:
Please put the 'DKB...' in the right alphabetical order 😃
(Between COOP and DOTS)

@zenminimalist
Copy link
Contributor Author

To keep the code clean: Please put the 'DKB...' in the right alphabetical order 😃 (Between COOP and DOTS)

download

You're right. I'm sooo sorry. Fixed. 😅

@matt-fidd
Copy link
Contributor

Hi! Thanks for this, you'll need to add a release note before I can merge it in.

https://actualbudget.com/docs/contributing/#writing-good-release-notes

@zenminimalist
Copy link
Contributor Author

Hi! Thanks for this, you'll need to add a release note before I can merge it in.

https://actualbudget.com/docs/contributing/#writing-good-release-notes

What's wrong with the one on the top of this post?

Add Deutsche Kreditbank AG (DKB) (DKB_BYLADEM1) to the 90-days sync limited list
Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sorry - I missed your earlier comment

@matt-fidd matt-fidd merged commit 2005c1b into actualbudget:master Dec 31, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants