Add default undefined option for payeename in KBC integration

[robxgd]

Added a default undefined option as Payeename for the KBC integration as this is not always available as described in issue: #532 .

[coderabbitai]

Walkthrough

The pull request introduces a modification to the normalizeTransaction method in the KBC Kredbebb bank synchronization file. The change specifically focuses on how the payeeName is determined for transactions with negative amounts. The primary alteration involves the assignment of payeeName when transaction.remittanceInformationUnstructured is present. The new implementation ensures that if the unstructured remittance information is truthy, it will be used; otherwise, the payeeName will be set to the string 'undefined'. The logic for positive amount transactions remains unchanged, continuing to prioritize transaction.debtorName for the payeeName. The overall structure of the method and the handling of the date property are preserved.

Possibly related PRs

• Improve abn amro sync #534: Changes in the normalizeTransaction method for the Abn Amro sync involving similar payeeName extraction modifications

Suggested labels

sparkles: Merged

Suggested reviewers

• matt-fidd

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (1)

src/app-gocardless/banks/kbc_kredbebb.js (1)

Line range hint 28-34: Consider adding the same fallback for negative amounts

While the positive amount case now has a fallback 'undefined' value, the negative amount case might still return undefined if both creditorName and the extracted payee name are falsy. Consider applying the same fallback pattern here for consistency.

      payeeName:
        transaction.creditorName ||
        extractPayeeNameFromRemittanceInfo(
          transaction.remittanceInformationUnstructured,
          ['Betaling met', 'Domiciliëring', 'Overschrijving'],
-        ),
+        ) || 'undefined',

🧹 Nitpick comments (1)

src/app-gocardless/banks/kbc_kredbebb.js (1)

Line range hint 11-13: Update JSDoc comment to reflect the fallback behavior

The current comment only describes the payee information source for negative amounts. Consider updating it to document the fallback behavior for both positive and negative amounts.

 /**
  * For negative amounts, the only payee information we have is returned in
  * remittanceInformationUnstructured.
+ * Falls back to 'undefined' if no payee information is available.
  */

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2005c1b and 8f08dec.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/533.md is excluded by !**/*.md

📒 Files selected for processing (1)

• src/app-gocardless/banks/kbc_kredbebb.js (1 hunks)

🔇 Additional comments (1)

src/app-gocardless/banks/kbc_kredbebb.js (1)

20-21: LGTM! The fallback value addition looks good.

The addition of 'undefined' as a fallback value for positive amount transactions aligns with the PR objective and ensures consistent payeeName handling when no value is available.

[MatissJanis]

LGTM