Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner case transaction for GoCardLess adapater (ING Romania) #535

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Corner case transaction for GoCardLess adapater (ING Romania) #535

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77ad1d7
Added special corner case
Jan 4, 2025
87f9341
One additional validation + Release notes
Jan 5, 2025
dbc6715
Merge branch 'master' into ing-adapter-fix-2025
spideraxal Jan 7, 2025
a8da2c9
Merge branch 'master' into ing-adapter-fix-2025
spideraxal Jan 7, 2025
7ee1fd2
Fixed duplicate code
Jan 7, 2025
5e10971
Improved comment
Jan 7, 2025
0b2f6b1
Improved comment
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/app-gocardless/banks/ing-ingbrobu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,17 @@ export default {
if (transaction.transactionId === 'NOTPROVIDED') {
if (booked) {
transaction.transactionId = transaction.internalTransactionId;

//Some corner case transactions have a special field called `proprietaryBankTransactionCode`, this need to be copied to `remittanceInformationUnstructured`
if (
transaction.proprietaryBankTransactionCode &&
!transaction.remittanceInformationUnstructured
) {
transaction.remittanceInformationUnstructured =
transaction.proprietaryBankTransactionCode;
}
spideraxal marked this conversation as resolved.
Show resolved Hide resolved
if (
transaction.remittanceInformationUnstructured &&
transaction.remittanceInformationUnstructured
.toLowerCase()
.includes('card no:')
Expand All @@ -32,7 +42,16 @@ export default {
}
} else {
transaction.transactionId = null;

if (
transaction.proprietaryBankTransactionCode &&
!transaction.remittanceInformationUnstructured
) {
transaction.remittanceInformationUnstructured =
transaction.proprietaryBankTransactionCode;
}
if (
transaction.remittanceInformationUnstructured &&
transaction.remittanceInformationUnstructured
.toLowerCase()
.includes('card no:')
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/535.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [spideraxal]
---

Add corner case transaction for ING Bank Romania
Loading