Refactor the start command and add unit tests
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change last test
Better Tests with more line coverage and correct line lenght.
Added comment for last Test: # This test just works with other start execute bc current one doesn't # have run_command_in_container and construct_command_line
Changed code for start.py: Outsourcing code from execute in functions for better readability and easier testing.
Added additional tests
Added a lot of tests to test the added help functions
adjust code bc of changes in the start.py
deleted and readded changes to start.py for working around problems with mergeing
joka921
changed the title
start command and add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
startcommand had a very longexecutefunction which as of this PR now is refactored into smaller functions(e.g. for handling the native or containerized starting and for killing preexisting binaries or containers with the same port.
Also add unit tests (using mock tests) for the
startcommand.