Support QLEVER_IS_RUNNING_IN_CONTAINER
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two environment variables are useful when running the qlever CLI within a Docker container, introduced by ad-freiburg/qlever#1439 The effect of QLEVER_OVERRIDE_SYSTEM_NATIVE is that after `qlever setup-config <config name>`, the Qleverfile will contain the setting `SYSTEM = native` and not `SYSTEM = docker`. The effect of QLEVER_OVERRIDE_DISABLE_UI is that `qlever ui` is disabled, which makes sense when running inside a container. In both cases, meaningful log message are provided for the user.
hannahbast
changed the title
QLEVER_OVERRIDE_SYSTEM_NATIVE and QLEVER_OVERRIDE_DISABLE_UI
hannahbast
changed the title
QLEVER_OVERRIDE_SYSTEM_NATIVE and QLEVER_OVERRIDE_DISABLE_UIQLEVER_IS_RUNNING_IN_CONTAINER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ad-freiburg/qlever#1439, the recommended way to run QLever inside a container is to use the https://github.com/ad-freiburg/qlever-control script. Inside of the container, the environment variable
QLEVER_IS_RUNNING_IN_CONTAINERis set, with the following two effects:qlever setup-config <config name>, the Qleverfile will contain the settingSYSTEM = nativeand notSYSTEM = dockerand a warning message will be displayed that that is the caseqlever ui, an error message will be displayed that this command is disabled (reason:qlever uiruns another container, and we don't want containers inside of containers).