Backport of some concepts from util to C++17

[gpicciuca]

Proposing a first bulk of changes aiming to backport some of the concepts used throughout the util module. (Not ready for merging)

There are some places where things are quite intricate and complicated, so feedback would be appreciated.

Problematic areas:

• SerializeVector.h ends up with an incomplete type when building with C++17 flag
• ConfigOptionProxy.h seems to not forward the underlying type correctly, causing the ValidatorFunction constraints to fail when using the addValidator method from ConfigOption.h (See commented code in BenchmarkExamples.cpp)
• A solution has to be found for the isInstantiation constraints imposed in some parts of ConfigOption.h, which I currently had to remove to make it build with v3-ranges.

[codecov]

Codecov Report

Attention: Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.95%. Comparing base (f2562fe) to head (d5d59b3).

Files with missing lines	Patch %	Lines
src/util/TypeTraits.h	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
- Coverage   89.95%   89.95%   -0.01%     
==========================================
  Files         395      395              
  Lines       37651    37664      +13     
  Branches     4234     4234              
==========================================
+ Hits        33869    33879      +10     
+ Misses       2487     2486       -1     
- Partials     1295     1299       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joka921]

Thank you very much,
I played around a bit and learned some things.
For the future, please tell me, which targets you compiled (I assume benchmark among others), or whether you manually compiled even single header files etc. Otherwise I also get many errors of things that would have been easy to fix.

I update your branch, so make sure to git pull and have a look at my changes first:

• General:

1. Inside a CPP_template_def you have to use CPP_and_def (which I just implemented) instead of CPP_and
2. Inside a CPP_template(_def) you have to use CPP_NOT(someConstraint) instead of !someConstraint.
   (I will also add those two points to the Wiki)

• SerializeVector.h ends up with an incomplete type when building with C++17 flag
  I found some issues with the AD_SERIALIZE_FUNCTION_WITH_CONSTRAINT macros (in particular they currently don't support commas inside their arguments, I worked around for some of them, have a look and see if you can fix your problem in a similar way.

• ConfigOptionProxy.h seems to not forward the underlying type correctly, causing the ValidatorFunction constraints to fail when using the addValidator method from ConfigOption.h (See commented code in BenchmarkExamples.cpp)
  This works now (the problem was, that std::invoke_result_t is not at all SFINAE-friendly, but still works with C++20 concepts. See my changes in TypeTraits.h for details.

• A solution has to be found for the isInstantiation constraints imposed in some parts of ConfigOption.h, which I currently had to remove to make it build with v3-ranges.

I have fixed the isInstantiation and (as a proof of concept) readded it to the first occurence in ConfigOption.h, feel free to extend it to the remaining occurences.

I hope that with these changes and suggestions you can continue, please let me know when there is additional trouble, then we can communicate further (probably next week).

[gpicciuca]

Thank you very much, I played around a bit and learned some things. For the future, please tell me, which targets you compiled (I assume benchmark among others), or whether you manually compiled even single header files etc. Otherwise I also get many errors of things that would have been easy to fix.

I update your branch, so make sure to git pull and have a look at my changes first:

• General:

1. Inside a CPP_template_def you have to use CPP_and_def (which I just implemented) instead of CPP_and
2. Inside a CPP_template(_def) you have to use CPP_NOT(someConstraint) instead of !someConstraint.
   (I will also add those two points to the Wiki)

• SerializeVector.h ends up with an incomplete type when building with C++17 flag
  I found some issues with the AD_SERIALIZE_FUNCTION_WITH_CONSTRAINT macros (in particular they currently don't support commas inside their arguments, I worked around for some of them, have a look and see if you can fix your problem in a similar way.

• ConfigOptionProxy.h seems to not forward the underlying type correctly, causing the ValidatorFunction constraints to fail when using the addValidator method from ConfigOption.h (See commented code in BenchmarkExamples.cpp)
  This works now (the problem was, that std::invoke_result_t is not at all SFINAE-friendly, but still works with C++20 concepts. See my changes in TypeTraits.h for details.

• A solution has to be found for the isInstantiation constraints imposed in some parts of ConfigOption.h, which I currently had to remove to make it build with v3-ranges.

I have fixed the isInstantiation and (as a proof of concept) readded it to the first occurence in ConfigOption.h, feel free to extend it to the remaining occurences.

I hope that with these changes and suggestions you can continue, please let me know when there is additional trouble, then we can communicate further (probably next week).

Thank you! For reference, I build the whole engine just to make sure that everything still builds especially since I'm currently working on the utility library which is used throughout a good portion of the codebase.

Will let you know if I spot more problems.

[sparql-conformance]

Conformance check passed ✅

No test result changes.

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=d5d59b3b71643d2ae7bfc0283315becebdd5cccc&prev=f2562fe2ca1da7e1704aa2a5b0473be08e5f296c

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud