Skip to content

Commit

Permalink
Document a nuance with the is_conda_cpython variable
Browse files Browse the repository at this point in the history
  • Loading branch information
adang1345 committed Nov 16, 2023
1 parent a893869 commit b1b9f50
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions delvewheel/_wheel_repair.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,17 @@
# vendored DLLs is added to the DLL search path. For Python 3.7 or lower, this
# function is unavailable, so we preload the DLLs. Whenever Python needs a
# vendored DLL, it will use the already-loaded DLL instead of searching for it.
# We also preload the DLLs for the versions of Anaconda Python < 3.10 that have
# a bug where os.add_dll_directory() does not always take effect
# We also preload the DLLs for the versions of Anaconda CPython < 3.10 that
# have a bug where os.add_dll_directory() does not always take effect
# (https://github.com/conda/conda/issues/10897).
#
# Strictly speaking, the is_conda_cpython variable in the patch does not always
# correctly detect whether Anaconda CPython is in use because newer versions of
# Anaconda CPython 3.8 and 3.9 no longer define the Anaconda_GetVersion()
# function. However, these versions do not have the os.add_dll_directory() bug,
# so we are still correctly detecting the versions of Anaconda Python that have
# the bug. Anaconda PyPy does not have the bug.
#
# The template must produce Python code that is compatible with Python 2.6, the
# oldest supported target Python version.
#
Expand Down

0 comments on commit b1b9f50

Please sign in to comment.